Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve std::any module doc #34749

Merged
merged 1 commit into from
Jul 12, 2016
Merged

Improve std::any module doc #34749

merged 1 commit into from
Jul 12, 2016

Conversation

GuillaumeGomez
Copy link
Member

Fixes #29340.

r? @steveklabnik

@frewsxcv
Copy link
Member 


failures:

---- any::Any + Send::downcast_mut_0 stdout ----
    <anon>:9:1: 9:2 error: unexpected close delimiter: `}`
<anon>:9 }
         ^
thread 'any::Any + Send::downcast_mut_0' panicked at 'Box<Any>', src/libsyntax/parse/mod.rs:258
note: Run with `RUST_BACKTRACE=1` for a backtrace.
thread 'any::Any + Send::downcast_mut_0' panicked at 'couldn't compile the test', src/librustdoc/test.rs:288

---- any::Any::downcast_mut_0 stdout ----
    <anon>:9:1: 9:2 error: unexpected close delimiter: `}`
<anon>:9 }

frewsxcv
frewsxcv reviewed Jul 10, 2016
View reviewed changes
src/libcore/any.rs
/// use std::any::Any;
///
/// fn modify_if_u32(s: &mut Any) {
/// /// if let Some(num) = s.downcast_mut::<u32>() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

/// ///

This seems problematic.

@steveklabnik
Copy link
Member

@bors: r+ rollup

@bors
Copy link
Contributor

bors commented Jul 11, 2016

📌 Commit 4c3cff6 has been approved by steveklabnik

@GuillaumeGomez GuillaumeGomez mentioned this pull request Jul 12, 2016
Merged
GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Jul 12, 2016
@GuillaumeGomez
Rollup merge of rust-lang#34749 - GuillaumeGomez:any_doc, r=steveklabnik
ea6cb87 
Improve std::any module doc

Fixes rust-lang#29340.

r? @steveklabnik
bors added a commit that referenced this pull request Jul 12, 2016
@bors
Auto merge of #34778 - GuillaumeGomez:rollup, r=GuillaumeGomez
31e9ed5 
Rollup of 7 pull requests

- Successful merges: #34736, #34737, #34740, #34742, #34749, #34750, #34770
- Failed merges: #33951
@bors bors merged commit 4c3cff6 into rust-lang:master Jul 12, 2016
@GuillaumeGomez GuillaumeGomez deleted the any_doc branch July 12, 2016 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@steveklabnik steveklabnik

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@GuillaumeGomez @frewsxcv @steveklabnik @bors