-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[doc] Fix links in Ownership section of the book #34442
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @steveklabnik (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
@@ -136,6 +136,8 @@ Rust allocates memory for an integer [i32] on the [stack][sh], copies the bit | |||
pattern representing the value of 10 to the allocated memory and binds the | |||
variable name x to this memory region for future reference. | |||
|
|||
[i32]: primitive-types.html#numeric-types |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm wondering if this shouldn't be put below. What do you think @steveklabnik?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is usually where I put such things, the paragraph after they're used.
@bors: r+ rollup Thank you! |
📌 Commit 26096c8 has been approved by |
…teveklabnik [doc] Fix links in Ownership section of the book - Add a missing link definition for `[i32]`. - Like `[stack]` link is pointing to `...#the-stack`, append `#the-heap` to `[heap]` link.
…teveklabnik [doc] Fix links in Ownership section of the book - Add a missing link definition for `[i32]`. - Like `[stack]` link is pointing to `...#the-stack`, append `#the-heap` to `[heap]` link.
…teveklabnik [doc] Fix links in Ownership section of the book - Add a missing link definition for `[i32]`. - Like `[stack]` link is pointing to `...#the-stack`, append `#the-heap` to `[heap]` link.
[i32]
.[stack]
link is pointing to...#the-stack
, append#the-heap
to[heap]
link.