Sendable futures #3421
Closed
Sendable futures #3421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the actual "fix" in this change is the chunk that moves `let x = self.consume()` to after the option dance that results in the `notify_chan` in TaskBuilder.try() the rest is cleanup/sense-making of what some of this code is doing (I'm looking at you, future_result)
|
This unblocks servo #43, which I'd also like to take on. |
|
Merged. Thanks! |
|
congrats pfox, this looks like it was a long slog. |
|
Yes, great work! Find us in #servo when you are ready to tackle that bug you unblocked |
RalfJung
pushed a commit
to RalfJung/rust
that referenced
this pull request
Mar 31, 2024
avoid mutating the global environment `remove_var` is just as bad as `set_var`, let's not do that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sendable futures in rust (plus other minor things)
Long time coming. Big thanks to @brson and @nikomatsakis for helping me over some spots where I got stuck.
Overview
Future<A>is now sendable (and not copyable)core::task(particularTaskBuilderandTaskOpts) now uses thepipes::family instead of thecomm::family of messaging primitivescoretypes that I touched during this minor changeCheers,
Jeff