Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix asm-misplaced-option on ARM/AArch64 #33753

Merged
merged 1 commit into from
May 27, 2016
Merged

Conversation

mmatyas
Copy link
Contributor

@mmatyas mmatyas commented May 20, 2016

This fixes #33737. Of course, since we don't run make check for ARM cross builds, you probably won't notice it.

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @brson (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@alexcrichton
Copy link
Member

Hm I believe the intention of this test was to only test x86/x86_64 because the assembly is unlikely to work on other platforms, it's just a relic of our test harness that we require the same messages on all architectures.

Could this test be updated with something like // ignore-aarch64 instead?

@mmatyas
Copy link
Contributor Author

mmatyas commented May 23, 2016

If this test only works on x86/64, wouldn't that mean adding // ignore- for every platform? Isn't there something like // only-on-?

I mean, I see there's a #[cfg(any(target_arch = ...))], but it doesn't seem to work well with #[rustc_error]. I think this is the only test that uses rustc_error with cfg, by the way.

@alexcrichton
Copy link
Member

Yeah unfortunately we don't have // only yet (although I think there's an issue for it), but for now it should suffice to just have a few // ignore directives, the test suite largely isn't running on multiple architectures.

@mmatyas
Copy link
Contributor Author

mmatyas commented May 24, 2016

Ok, updated.

@alexcrichton
Copy link
Member

@bors: r+ ba8d46e rollup

Thanks!

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request May 27, 2016
Fix `asm-misplaced-option` on ARM/AArch64

This fixes rust-lang#33737. Of course, since we don't run `make check` for ARM cross builds, you probably won't notice it.
bors added a commit that referenced this pull request May 27, 2016
Rollup of 10 pull requests

- Successful merges: #33753, #33815, #33829, #33858, #33865, #33866, #33870, #33874, #33891, #33898
- Failed merges:
@bors bors merged commit ba8d46e into rust-lang:master May 27, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compiler test asm-misplaced-option fails on AArch64 Linux
5 participants