Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace german by english word #33655

Closed
wants to merge 1 commit into from
Closed

Replace german by english word #33655

wants to merge 1 commit into from

Conversation

ParadoxSpiral
Copy link

@ParadoxSpiral ParadoxSpiral commented May 15, 2016

Credit to finding goes to SusWombat on freenode.

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @steveklabnik (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@GuillaumeGomez
Copy link
Member

Wo, weird. 😮

Thanks!

r=me @steveklabnik

@hanna-kruppe
Copy link
Contributor

hanna-kruppe commented May 15, 2016

Isn't "verboten" a loanword in English, with slightly stronger meaning than "forbidden"? I mean, I'm German so I can't judge how weird this is for English speakers who don't know German, but I was under the impression that this is perfectly valid English.

Not that it shouldn't be changed if it trips up enough people.

@apasel422
Copy link
Contributor

@ParadoxSpiral
Copy link
Author

Oh, didn't know that.
Is there some way to make a comment that won't be displayed, to prevent iteration 4 of this PR?
Something like: "Note: verboten is a legal english word. See https://www.oxforddictionaries.com/de/definition/englisch/verboten"

@steveklabnik
Copy link
Member

Yes, @rkruppe is right. Just like how "ballet" is a French word that's English by now.

Anywho, as I'm re-writing the book right now, this will eventually just go away, and I still ultimately like it. So thanks for the PR, but I'm gonna let it live in the book a little while longer 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants