Rollup of 7 pull requests #33349
Closed
Rollup of 7 pull requests #33349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
steveklabnik
commented
May 2, 2016
steveklabnik
commented
- Successful merges: Doc improvement on std::fmt module #33129, add help on pattern guard #33260, Fix std::fmt format spec: named args are allowed with "$" syntax #33277, Add detailed error explanation for E0501 #33294, doc/book/getting-started.md: Spelling correction and revised wording. #33322, std::thread docs: spawn() does not return a Thread anymore #33326, typeck: if a private field exists, also check for a public method #33342
- Failed merges: Fix link in relnotes #32912
…cutable from 'Converting to Cargo'.
Also move the "Thread type" section down a bit, since it is not so important anymore. Fixes: rust-lang#33321
fix too long column fix typo of help on pattern guard one nit
For example, `Vec::len` is both a field and a method, and usually encountering `vec.len` just means that the parens were forgotten. Fixes: rust-lang#26472
Doc improvement on std::fmt module Part of rust-lang#29355. r? @steveklabnik
…illaumeGomez add help on pattern guard
…=steveklabnik Fix std::fmt format spec: named args are allowed with "$" syntax
Add detailed error explanation for E0501 r? @GuillaumeGomez Bring on the nits!
doc/book/getting-started.md: Spelling correction and revised wording. The word 'Internet' was spelt with both an uppercase and a lowercase 'I'. The correct spelling seems to be a matter of some debate these days, however the first occurrence in the file has an uppercase 'I', so I've changed the second occurrence to suit for consistency. Under the section titled 'Converting to Cargo', there's mention of creating a new executable. This, however, is not part of the process described. I've revised the wording to reflect as much. Small changes, but I hope they are of benefit! :-) r? @steveklabnik
…Gomez std::thread docs: spawn() does not return a Thread anymore Also move the "Thread type" section down a bit, since it is not so important anymore. Fixes: rust-lang#33321
typeck: if a private field exists, also check for a public method For example, `Vec::len` is both a field and a method, and usually encountering `vec.len` just means that the parens were forgotten. Fixes: rust-lang#26472 NOTE: I added the parameter `allow_private` to `method::exists` since I don't want to suggest inaccessible methods. For the second case, where only the method exists, I think it would make sense to set it to `false` as well, but I wanted to preserve compatibility for this case.
|
r? @jroesch (rust_highfive has picked a reviewer for you, use r? to override) |
|
@bors: r+ p=1 |
|
📌 Commit 90c2a63 has been approved by |
|
⌛ Testing commit 90c2a63 with merge 579f8fc... |
|
💔 Test failed - auto-mac-64-opt-rustbuild |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.