-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Short-cut T: Sized
trait selection for ADTs
#33138
Merged
Merged
Commits on May 3, 2016
-
Short-cut Sized matching on ADTs
Put a constraint type on every ADT def, such that the ADT def is sized iff the constraint type is, and use that in selection. This ignores types that are obviously sized. This improves typeck performance by ~15%.
Configuration menu - View commit details
-
Copy full SHA for 73f39a0 - Browse repository at this point
Copy the full SHA 73f39a0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4bcabbd - Browse repository at this point
Copy the full SHA 4bcabbdView commit details -
Configuration menu - View commit details
-
Copy full SHA for babb5df - Browse repository at this point
Copy the full SHA babb5dfView commit details -
require the non-last elements of a tuple to be Sized
This requirement appears to be missing from RFC1214, but is clearly necessary for translation. The last field of a tuple/enum remains in a state of limbo, compiling but causing an ICE when it is used - we should eventually fix that somehow. this is a [breaking-change] - a soundness fix - and requires a crater run.
Configuration menu - View commit details
-
Copy full SHA for 0a6dfc5 - Browse repository at this point
Copy the full SHA 0a6dfc5View commit details -
require the existential bounds of an object type to be object-safe
This is required, as Copy and Sized are object-unsafe. As a soundness fix, this is a [breaking-change] Fixes rust-lang#32963
Configuration menu - View commit details
-
Copy full SHA for 2f8f256 - Browse repository at this point
Copy the full SHA 2f8f256View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6fc19ad - Browse repository at this point
Copy the full SHA 6fc19adView commit details -
Configuration menu - View commit details
-
Copy full SHA for 05f1a05 - Browse repository at this point
Copy the full SHA 05f1a05View commit details -
Configuration menu - View commit details
-
Copy full SHA for 5876b4b - Browse repository at this point
Copy the full SHA 5876b4bView commit details -
change the newly-added errors to warnings
this commit should be reverted after a release cycle
Configuration menu - View commit details
-
Copy full SHA for 6057a7f - Browse repository at this point
Copy the full SHA 6057a7fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 62db786 - Browse repository at this point
Copy the full SHA 62db786View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6c88384 - Browse repository at this point
Copy the full SHA 6c88384View commit details
Commits on May 4, 2016
-
Configuration menu - View commit details
-
Copy full SHA for 238e4ee - Browse repository at this point
Copy the full SHA 238e4eeView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.