-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Doc fix: Do not mention next project in book/guessing-game #32937
Doc fix: Do not mention next project in book/guessing-game #32937
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Manishearth (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
Perhaps remove this entirely? |
@Manishearth as a beginner, I like the old one better. It informs me that:
Just telling me that i have completed a challenge feels worse by comparison I would have liked another problem to go through. but when will that stop :-) |
Yes, but it seems a bit out of place. The chapter was already concluded with the previous sentence. If this could be moved above and edited to make more sense that would be fine. |
@Manishearth ok. fixing it |
The next project refers to the dining-philosophers problem https://github.com/rust-lang/rust/blob/27a1834ce522e3ec7fe4726b1661de16ee30c503/src/doc/book/dining-philosophers.md which was removed in rust-lang@0c6c34d so removing reference to that project from book/guessing-game
54a397e
to
a40629d
Compare
@bors r+ rollup thanks! |
📌 Commit a40629d has been approved by |
…roject-in-guessing-game-doc, r=Manishearth Doc fix: Do not mention next project in book/guessing-game fixes rust-lang#32936
⌛ Testing commit a40629d with merge c7b1d45... |
💔 Test failed - auto-win-gnu-32-opt |
@bors: retry On Thu, Apr 14, 2016 at 1:02 PM, bors [email protected] wrote:
|
fixes #32936