Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc fix: Do not mention next project in book/guessing-game #32937

Conversation

deepak
Copy link
Contributor

@deepak deepak commented Apr 13, 2016

fixes #32936

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Manishearth (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@Manishearth
Copy link
Member

Perhaps remove this entirely?

@deepak
Copy link
Contributor Author

deepak commented Apr 13, 2016

@Manishearth as a beginner, I like the old one better. It informs me that:

  1. I have successfully completed a challenge. feels good
  2. I have learnt a bunch of stuff. feels good again
  3. I can look forward to another problem. looking forward to feeling good again

Just telling me that i have completed a challenge feels worse by comparison
but that is just me probably

I would have liked another problem to go through. but when will that stop :-)

@Manishearth
Copy link
Member

Yes, but it seems a bit out of place. The chapter was already concluded with the previous sentence. If this could be moved above and edited to make more sense that would be fine.

@deepak
Copy link
Contributor Author

deepak commented Apr 13, 2016

@Manishearth ok. fixing it

The next project refers to the dining-philosophers problem
https://github.com/rust-lang/rust/blob/27a1834ce522e3ec7fe4726b1661de16ee30c503/src/doc/book/dining-philosophers.md

which was removed in
rust-lang@0c6c34d

so removing reference to that project from book/guessing-game
@deepak deepak force-pushed the gh-issue-32936-remove-next-project-in-guessing-game-doc branch from 54a397e to a40629d Compare April 13, 2016 16:24
@Manishearth
Copy link
Member

@bors r+ rollup

thanks!

@bors
Copy link
Contributor

bors commented Apr 13, 2016

📌 Commit a40629d has been approved by Manishearth

steveklabnik added a commit to steveklabnik/rust that referenced this pull request Apr 14, 2016
…roject-in-guessing-game-doc, r=Manishearth

Doc fix: Do not mention next project in book/guessing-game

fixes rust-lang#32936
@bors
Copy link
Contributor

bors commented Apr 14, 2016

⌛ Testing commit a40629d with merge c7b1d45...

@bors
Copy link
Contributor

bors commented Apr 14, 2016

💔 Test failed - auto-win-gnu-32-opt

@alexcrichton
Copy link
Member

@bors: retry

On Thu, Apr 14, 2016 at 1:02 PM, bors [email protected] wrote:

[image: 💔] Test failed - auto-win-gnu-32-opt
http://buildbot.rust-lang.org/builders/auto-win-gnu-32-opt/builds/3808


You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
#32937 (comment)

bors added a commit that referenced this pull request Apr 14, 2016
@bors bors merged commit a40629d into rust-lang:master Apr 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs: add link for the next project in the guessing-game doc
5 participants