-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Book: Fix phrasing: “an associated type” → “an object with an associated type”. #32618
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @steveklabnik (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
@@ -131,7 +131,7 @@ declarations. | |||
## Trait objects with associated types | |||
|
|||
There’s one more bit of syntax we should talk about: trait objects. If you | |||
try to create a trait object from an associated type, like this: | |||
try to create a trait object from an object with an associated type, like this: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would say that "from a trait with an associated type" is somewhat more accurate.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changed.
bfa1e6b
to
b1b3738
Compare
@bors: r+ rollup thank you! |
📌 Commit b1b3738 has been approved by |
Book: Fix phrasing: “an associated type” → “an object with an associated type”. From what I understood, `graph` is the object from which we create a trait object, and the associated types are `Graph::N` and `Graph::E`.
From what I understood,
graph
is the object from which we create a trait object, and the associated types areGraph::N
andGraph::E
.