Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalize return type when checking for E0269 #32228

Merged
merged 3 commits into from
Mar 16, 2016
Merged

Normalize return type when checking for E0269 #32228

merged 3 commits into from
Mar 16, 2016

Conversation

jonas-schievink
Copy link
Contributor

Fixes #31597

First time dealing with normalization. Maybe normalize_associated_type would be better here, but it seems to imply it's only used during trans.

let norm = traits::normalize(&mut selcx,
cause,
&t_ret);

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use fully_normalize, not normalize.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What should I do with possible errors? I'm assuming they would already be reported elsewhere, so should I just drop them and assume the result is (or is not) ()? Or can errors not occur here, since liveness runs so late in the pipeline?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There should not be any errors. Just remember to pass the parameter environment!

@jonas-schievink
Copy link
Contributor Author

Okay, that should do it

@arielb1
Copy link
Contributor

arielb1 commented Mar 13, 2016

@bors r+

@bors
Copy link
Contributor

bors commented Mar 13, 2016

📌 Commit b757330 has been approved by arielb1

@bors
Copy link
Contributor

bors commented Mar 14, 2016

⌛ Testing commit b757330 with merge 1b80e30...

@bors
Copy link
Contributor

bors commented Mar 14, 2016

💔 Test failed - auto-win-gnu-32-opt

@jonas-schievink
Copy link
Contributor Author

Looks like a timeout

@sanxiyn
Copy link
Member

sanxiyn commented Mar 16, 2016

@bors retry

@bors
Copy link
Contributor

bors commented Mar 16, 2016

⌛ Testing commit b757330 with merge b660c98...

@bors
Copy link
Contributor

bors commented Mar 16, 2016

💔 Test failed - auto-linux-64-opt

@jonas-schievink
Copy link
Contributor Author

Fixed

@sanxiyn
Copy link
Member

sanxiyn commented Mar 16, 2016

@bors r+

@bors
Copy link
Contributor

bors commented Mar 16, 2016

📌 Commit 96d9408 has been approved by sanxiyn

@bors
Copy link
Contributor

bors commented Mar 16, 2016

⌛ Testing commit 96d9408 with merge fd5603b...

bors added a commit that referenced this pull request Mar 16, 2016
Normalize return type when checking for E0269

Fixes #31597

First time dealing with normalization. Maybe `normalize_associated_type` would be better here, but it seems to imply it's only used during trans.
@bors bors merged commit 96d9408 into rust-lang:master Mar 16, 2016
@jonas-schievink jonas-schievink deleted the diag1 branch March 16, 2016 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants