-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Normalize return type when checking for E0269 #32228
Conversation
let norm = traits::normalize(&mut selcx, | ||
cause, | ||
&t_ret); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use fully_normalize
, not normalize
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What should I do with possible errors? I'm assuming they would already be reported elsewhere, so should I just drop them and assume the result is (or is not) ()
? Or can errors not occur here, since liveness runs so late in the pipeline?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There should not be any errors. Just remember to pass the parameter environment!
Okay, that should do it |
@bors r+ |
📌 Commit b757330 has been approved by |
⌛ Testing commit b757330 with merge 1b80e30... |
💔 Test failed - auto-win-gnu-32-opt |
Looks like a timeout |
@bors retry |
⌛ Testing commit b757330 with merge b660c98... |
💔 Test failed - auto-linux-64-opt |
Fixed |
@bors r+ |
📌 Commit 96d9408 has been approved by |
Normalize return type when checking for E0269 Fixes #31597 First time dealing with normalization. Maybe `normalize_associated_type` would be better here, but it seems to imply it's only used during trans.
Fixes #31597
First time dealing with normalization. Maybe
normalize_associated_type
would be better here, but it seems to imply it's only used during trans.