rustdoc: Smallish refactor #31967
rustdoc: Smallish refactor #31967
Conversation
|
☔ The latest upstream changes (presumably #31979) made this pull request unmergeable. Please resolve the merge conflicts. |
Since we emit the sources beforhand we actually **know** whether we can safely create src-links to these files and where they are stored.
|
(rebased) |
| } | ||
| None => {} | ||
| } | ||
| cx.tcx_opt().map(|tcx| { |
There was a problem hiding this comment.
Stylistically we tend to use if let Some(...) for imperative computations rather than .map(..) on Option
There was a problem hiding this comment.
This shows up in a number of other places as well, but otherwise 512c5cdc0f340cba2b8fc86436cca49f963912a8 looks like great cleanup!
|
Thanks @mitaa! Overall looks like a fantastic refactor to me. |
|
(updated) |
|
⌛ Testing commit 938c8c1 with merge 34caf4a... |
|
💔 Test failed - auto-mac-64-opt |
|
@bors: retry On Sat, Mar 5, 2016 at 11:16 PM, bors [email protected] wrote:
|
This is mostly cleanup of individual code bits and code reuse for `clean::Attribute` handling. The only change in behaviour should be that emitted sources are now being recorded and queried when trying to create src-links to local source-files. r? @alexcrichton
This is mostly cleanup of individual code bits and code reuse for
clean::Attributehandling.The only change in behaviour should be that emitted sources are now being recorded and queried when trying to create src-links to local source-files.
r? @alexcrichton