Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustdoc: Don't inline impls from doc(hidden) modules #31903

Merged
merged 1 commit into from
Feb 26, 2016

Conversation

mitaa
Copy link
Contributor

@mitaa mitaa commented Feb 26, 2016

@mitaa
Copy link
Contributor Author

mitaa commented Feb 26, 2016

I'm not entirely sure if this is the right fix. On the one hand this is already done when inlining specific impls, but OTOH there is the pass strip-hidden which this maybe should be somehow coupled to.

edit: Well, I'm sure that this is the right fix, just not sure whether this should also be somehow toggled by strip-hidden

@alexcrichton
Copy link
Member

Hm, it's tough to say what the interaction should be here is. Items can be exported from a #[doc(hidden)] module but then again you may also want to hide everything in a #[doc(hidden)] module.

Right now I think it's a rare enough pattern that we should take this for now, however. Can you be sure to add a test for this though?

@mitaa mitaa force-pushed the rdoc-ghostly-impls branch from 9d928bc to eae9f46 Compare February 26, 2016 14:57
@mitaa
Copy link
Contributor Author

mitaa commented Feb 26, 2016

Forgot to commit the test.. 😐

(updated)

@alexcrichton
Copy link
Member

@bors: r+ eae9f46

@bors
Copy link
Contributor

bors commented Feb 26, 2016

⌛ Testing commit eae9f46 with merge 64b4b6d...

@bors bors merged commit eae9f46 into rust-lang:master Feb 26, 2016
@mitaa mitaa deleted the rdoc-ghostly-impls branch February 27, 2016 04:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

404 link in std docs
3 participants