Nomicon: Vec ZST a few code fixes #30952
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Manishearth (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
|
r? @gankro |
|
The indentation of those let x = if foo() {
a
} else {
b
}But maybe the community has drifted from that? |
|
r=me on the content of the patch, though |
| @@ -226,7 +226,11 @@ impl<T> Iterator for RawValIter<T> { | |||
| } else { | |||
| unsafe { | |||
| let result = ptr::read(self.start); | |||
| self.start = self.start.offset(1); | |||
| self.start = if mem::size_of::<T>() == 0 { | |||
| (self.start as usize + 1) as *const _ | |||
There was a problem hiding this comment.
It looks like you have literal tabs in the file, you should indent with only spaces.
|
Damn Emacs config ... |
… r=Gankro * Moved semicolon to the right place in the `let` statement in the ZST section. * Fixed the missing ZST additions for `RawValIter<T>` from this section in the final code section.
letstatement in the ZST section.RawValIter<T>from this section in the final code section.