Rustfmt librustc unicode #29295
Rustfmt librustc unicode #29295
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
|
r? @nrc |
| @@ -38,6 +38,7 @@ | |||
| // NOTE: The following code was generated by "src/etc/unicode.py", do not edit directly | |||
|
|
|||
| #![allow(missing_docs, non_upper_case_globals, non_snake_case)] | |||
| // #![rustfmt_skip] | |||
There was a problem hiding this comment.
Should remove rather than comment this.
|
Looks good, thanks for the PR! r+ with the skip comments removed and the commits squashed. |
|
@nrc thank you :) I fixed according to your comments and rebased. |
|
@bors: r+ |
|
📌 Commit 1bb7205 has been approved by |
I didn't see anything particularly weird here. The last commit has the only changes I'm not 100% sure about. I ignored tables.rs since it's genrated, but I updated the python script that generates it. ?r @nrc
I didn't see anything particularly weird here. The last commit has the only changes I'm not 100% sure about.
I ignored tables.rs since it's genrated, but I updated the python script that generates it.
?r @nrc