Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround for #28871 #29241

Merged
merged 4 commits into from
Oct 23, 2015
Merged

Workaround for #28871 #29241

merged 4 commits into from
Oct 23, 2015

Conversation

nikomatsakis
Copy link
Contributor

Give preference to projections from where-clauses over those from trait definitions. This makes #28871 work again, though I think there's more to fix in this general area.

r? @arielb1
cc @brson (fixes regression)

trait definitions, and give prefence to the former. This is consistent
with what we do for selection. It also works around a limitation
that was leading to rust-lang#28871.
@brson brson added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Oct 22, 2015
@brson
Copy link
Contributor

brson commented Oct 22, 2015

@rust-lang/lang nominating this for backport to beta. I'd like to do so tomorrow.

@nikomatsakis
Copy link
Contributor Author

Presuming we opt to land it, I'm ok w/ backporting this; it's a very minor patch, fixes a regression. (That was, indeed, the point.)

@arielb1
Copy link
Contributor

arielb1 commented Oct 23, 2015

@nikomatsakis

I would prefer to normalize the projection's trait-ref (so they will deduplicate), but I guess this makes sense too.

@arielb1
Copy link
Contributor

arielb1 commented Oct 23, 2015

r+ modulo the test working.

@nikomatsakis
Copy link
Contributor Author

@arielb1

I would prefer to normalize the projection's trait-ref (so they will
deduplicate), but I guess this makes sense too.

In general I prefer that as well. I didn't have much time yesterday so I
added this as a quick fix, since it seemed to (as you say) also make sense.
It's certainly consistent with our strategy elsewhere, and I think that it
won't make any (useful) programs work that won't also work later as we
improve our strategy.

On Fri, Oct 23, 2015 at 9:20 AM, arielb1 [email protected] wrote:

r+ modulo the test working.


Reply to this email directly or view it on GitHub
#29241 (comment).

@arielb1
Copy link
Contributor

arielb1 commented Oct 23, 2015

@bors r+

@bors
Copy link
Contributor

bors commented Oct 23, 2015

📌 Commit b69e08c has been approved by arielb1

@nikomatsakis nikomatsakis added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Oct 23, 2015
@nikomatsakis
Copy link
Contributor Author

Given the time frame, I'm going to declare this beta-accepted, as I don't anticipate any objections from @rust-lang/lang members. Let me know if I am mistaken.

@bors
Copy link
Contributor

bors commented Oct 23, 2015

⌛ Testing commit b69e08c with merge bbb5f8e...

bors added a commit that referenced this pull request Oct 23, 2015
Give preference to projections from where-clauses over those from trait definitions. This makes #28871 work again, though I think there's more to fix in this general area.

r? @arielb1 
cc @brson (fixes regression)
@bors bors merged commit b69e08c into rust-lang:master Oct 23, 2015
@brson brson mentioned this pull request Oct 24, 2015
@brson brson removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Oct 24, 2015
@nikomatsakis nikomatsakis deleted the issue-28871 branch March 30, 2016 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta-accepted Accepted for backporting to the compiler in the beta channel.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants