Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't build empty compiler-rt.lib on Windows MSVC at all #28636

Closed
wants to merge 4 commits into from
Closed

Don't build empty compiler-rt.lib on Windows MSVC at all #28636

wants to merge 4 commits into from

Conversation

angelsl
Copy link
Contributor

@angelsl angelsl commented Sep 24, 2015

Depends on #28611, #28633, and blocked on next snapshot containing those two.

Once our bootstrap snapshot doesn't link to compiler-rt on MSVC, we can stop building compiler-rt.lib completely.

r? @alexcrichton

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@alexcrichton
Copy link
Member

Thanks for the PR! I'm not sure, however, that we'll be able to land #28611 soon, so I'm gonna close this waiting for that to be resolved. If that's merged soon, however, I'll try to reopen this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants