Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not drop_in_place elements of Vec<T> if T doesn't need dropping #28531

Merged
merged 3 commits into from
Sep 21, 2015
Merged

Do not drop_in_place elements of Vec<T> if T doesn't need dropping #28531

merged 3 commits into from
Sep 21, 2015

Commits on Sep 20, 2015

  1. Do not drop_in_place elements of Vec<T> if T doesn't need dropping 

    With -O2, LLVM's inliner can remove this code, but this does not happen
with -O1 and lower. As a result, dropping Vec<u8> was linear with length,
resulting in abysmal performance for large buffers.
    @whitequark
    whitequark committed Sep 20, 2015
    Configuration menu
    Copy the full SHA
    c5fa777 View commit details
    Browse the repository at this point in the history

  2. Fix style.

    @whitequark
    whitequark committed Sep 20, 2015
    Configuration menu
    Copy the full SHA
    6beb4ba View commit details
    Browse the repository at this point in the history

  3. Add comment.

    @whitequark
    whitequark committed Sep 20, 2015
    Configuration menu
    Copy the full SHA
    77f5da7 View commit details
    Browse the repository at this point in the history