-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
E0283 error explain #28469
E0283 error explain #28469
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Aatch (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
I haven't this check fail locally. What to do? Fix and repeat? Are there another flaws in the PR? |
@@ -1900,7 +1951,7 @@ register_diagnostics! { | |||
E0278, // requirement is not satisfied | |||
E0279, // requirement is not satisfied | |||
E0280, // requirement is not satisfied | |||
E0283, // cannot resolve type | |||
// E0283, // cannot resolve type |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove the line.
@deniskolodin Can you squash the commits? |
It looks complete. Something else? |
r? @Manishearth |
} | ||
``` | ||
|
||
Also you can use generic type if binding isn't ambiguous: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
a generic type if the binding
I'm not actually sure what this comment is saying we should do, perhaps you meant "use a type hint"?
I've fixed text and removed the last example, because It offers another design, but not a solution. Check the result, please. |
} | ||
``` | ||
|
||
To resolve use the concrete type: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"To resolve this error use the concrete type:" instead seems better.
@bors: r+ rollup Sorry this took so long to get in, @deniskolodin |
📌 Commit 50b43f6 has been approved by |
No description provided.