Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Never create allocas for indirect function arguments #27687

Closed
wants to merge 1 commit into from
Closed

Never create allocas for indirect function arguments #27687

wants to merge 1 commit into from

Commits on Aug 12, 2015

  1. Never create allocas for indirect function arguments 

    The assertion that argument debuginfo always has to be assigned to
allocas only exists in rustc, not in LLVM. The reason for that assertion
might have been that we used to created bad debuginfo for closures which
did indeed lead to errors when we skipped the alloca, but this was fixed
in commit 218eccf "Fix de-deduplication for closure debuginfo".

So now we can always skip the alloca for indirect arguments, even when
generating debuginfo.
    @dotdash
    dotdash committed Aug 12, 2015
    Configuration menu
    Copy the full SHA
    98258e3 View commit details
    Browse the repository at this point in the history