trans: Re-enable unwinding on 64-bit MSVC #27676
Merged
+55
−23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @jroesch (rust_highfive has picked a reviewer for you, use r? to override) |
alexcrichton
force-pushed
the
msvc-unwind
branch
from
5360e41
to
457e40c
Compare
|
cc @vadimcn |
|
👍 sweet |
| /// This is only true for MSVC targets, and even then the 64-bit MSVC target | ||
| /// currently uses SEH-ish unwinding with DWARF info tables to the side (same as | ||
| /// 64-bit MinGW) instead of "full SEH". | ||
| pub fn wants_seh(sess: &Session) -> bool { |
There was a problem hiding this comment.
I find this nomenclature confusing: the format of LSDA is not a part of the SEH spec, so both -gnu and -msvc are "full SEH". I think this should be called wants_msvc_lsda, or at least wants_msvc_seh.
This commit leverages the runtime support for DWARF exception info added in rust-lang#27210 to enable unwinding by default on 64-bit MSVC. This also additionally adds a few minor fixes here and there in the test harness and such to get `make check` entirely passing on 64-bit MSVC: * The invocation of `maketest.py` now works with spaces/quotes in CC * debuginfo tests are disabled on MSVC * A link error for librustc was hacked around (see rust-lang#27438)
alexcrichton
force-pushed
the
msvc-unwind
branch
from
457e40c
to
b6b4f5a
Compare
|
@bors r+ |
|
📌 Commit b6b4f5a has been approved by |
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Aug 12, 2015
This commit leverages the runtime support for DWARF exception info added in rust-lang#27210 to enable unwinding by default on 64-bit MSVC. This also additionally adds a few minor fixes here and there in the test harness and such to get `make check` entirely passing on 64-bit MSVC: * The invocation of `maketest.py` now works with spaces/quotes in CC * debuginfo tests are disabled on MSVC * A link error for librustc was hacked around (see rust-lang#27438)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit leverages the runtime support for DWARF exception info added
in #27210 to enable unwinding by default on 64-bit MSVC. This also additionally
adds a few minor fixes here and there in the test harness and such to get
make checkentirely passing on 64-bit MSVC:maketest.pynow works with spaces/quotes in CC