Recursive elseif #273
Merged
Recursive elseif #273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conflicts: src/Makefile src/comp/front/ast.rs src/comp/front/parser.rs src/comp/middle/fold.rs src/comp/middle/trans.rs
Doesn't seem to break anything and allows trans_if to be streamlined
Conflicts: src/comp/middle/typeck.rs
oli-obk
added a commit
to oli-obk/rust
that referenced
this pull request
Sep 19, 2017
Test that &* of a dangling (and even unaligned) ptr is okay
keeperofdakeys
pushed a commit
to keeperofdakeys/rust
that referenced
this pull request
Dec 12, 2017
Bump to 0.2.11 Closes rust-lang#273
kazcw
pushed a commit
to kazcw/rust
that referenced
this pull request
Oct 23, 2018
dlrobertson
pushed a commit
to dlrobertson/rust
that referenced
this pull request
Nov 29, 2018
Add 128-bit to types
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This redefines expr_if as a condition, if block, and optional else expression, which may be either expr_if or expr_block. You preferred this option less than the existing definition last time around, but marijn expressed a preference for this one, and it makes most code paths involved simpler, so I'm proposing it again.
Please note what I did in 2a66294 though. I removed some generated code around expr_block to remove a FIXME. The tests still pass, but I can't say that I really understood what I changed.