Don't call instantiate_type_scheme during method probing #26282
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It can introduce obligations to the fulfillment context, which would incorrectly still remain after the probe finished. Fixes rust-lang#25679.
|
These changes definitely emphasize the need to reshuffle our contexts around, so that we can manage all the state in one transaction. @jroesch is doing some of the starting work on that right now. |
|
@bors r+ |
|
📌 Commit 6cdccc5 has been approved by |
arielb1
pushed a commit
to arielb1/rust
that referenced
this pull request
Jun 15, 2015
This adds transaction support to fulfill. I can't use it in rust-lang#26282 because that would require nested transactions. This doesn't seem to cause compilation time to regress. Fixes rust-lang#24819.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It can introduce obligations to the fulfillment context, which would
incorrectly still remain after the probe finished.
Fixes #25679.
r? @eddyb