Translate "ignored" closure expressions. #26079
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @pcwalton (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. The way Github handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
|
r? @nrc |
| // Even if we don't have a value to emit, and the expression | ||
| // doesn't have any side-effects, we still have to translate the | ||
| // body of any closures. | ||
| // TOOD: Find a better way of handling this case. |
There was a problem hiding this comment.
typo - TOOD - should be FIXME (TOOD will break make tidy)
|
r=me modulo the typo |
|
Updated. |
|
Thanks! Could you squash the commits together as well? |
This isn't a very clean fix, but I'm not sure what a better fix would look like. Fixes rust-lang#24779.
|
Squashed. |
|
@bors: r=nrc 22442f83 |
|
🙀 |
This isn't a very clean fix, but I'm not sure what a better fix would look like. Fixes #24779.
This isn't a very clean fix, but I'm not sure what a better fix would look
like.
Fixes #24779.