Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip useless recursion in freshening and late-bound-region substitution #26055

Merged
merged 1 commit into from
Jun 10, 2015

Conversation

arielb1
Copy link
Contributor

@arielb1 arielb1 commented Jun 6, 2015

Before:
581.72user 4.75system 7:42.74elapsed 126%CPU (0avgtext+0avgdata 1176224maxresident)k
llvm took 359.183

After:
550.63user 5.09system 7:20.28elapsed 126%CPU (0avgtext+0avgdata 1165516maxresident)k
llvm took 354.801

@rust-highfive
Copy link
Collaborator

r? @pnkfelix

(rust_highfive has picked a reviewer for you, use r? to override)

@arielb1
Copy link
Contributor Author

arielb1 commented Jun 6, 2015

r? @nikomatsakis

@arielb1 arielb1 changed the title Skip useless recursion in freshening and late-bound-region substitutio Skip useless recursion in freshening and late-bound-region substitution Jun 6, 2015
@bors
Copy link
Contributor

bors commented Jun 8, 2015

☔ The latest upstream changes (presumably #26018) made this pull request unmergeable. Please resolve the merge conflicts.

Before:
581.72user 4.75system 7:42.74elapsed 126%CPU (0avgtext+0avgdata 1176224maxresident)k
llvm took 359.183

After:
550.63user 5.09system 7:20.28elapsed 126%CPU (0avgtext+0avgdata 1165516maxresident)k
llvm took 354.801
@arielb1
Copy link
Contributor Author

arielb1 commented Jun 8, 2015

Rebased

@nikomatsakis
Copy link
Contributor

@bors r+ Looks nice! Sorry, been neglecting my review queue last few days...

@bors
Copy link
Contributor

bors commented Jun 9, 2015

📌 Commit 39b9bea has been approved by nikomatsakis

@bors
Copy link
Contributor

bors commented Jun 10, 2015

⌛ Testing commit 39b9bea with merge 5ea3ed0...

bors added a commit that referenced this pull request Jun 10, 2015
Before:
581.72user 4.75system 7:42.74elapsed 126%CPU (0avgtext+0avgdata 1176224maxresident)k
llvm took 359.183

After:
550.63user 5.09system 7:20.28elapsed 126%CPU (0avgtext+0avgdata 1165516maxresident)k
llvm took 354.801
@bors bors merged commit 39b9bea into rust-lang:master Jun 10, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants