Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make stability attributes an error. #22830 #24646

Merged
merged 1 commit into from
Apr 21, 2015
Merged

Conversation

brson
Copy link
Contributor

@brson brson commented Apr 21, 2015

No description provided.

@brson brson added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Apr 21, 2015
@rust-highfive
Copy link
Collaborator

r? @alexcrichton

(rust_highfive has picked a reviewer for you, use r? to override)

#[unstable] //~ WARNING: stability attributes are deprecated
#[stable] //~ WARNING: stability attributes are deprecated
#[deprecated] //~ WARNING: stability attributes are deprecated
#[unstable] //~ WARNING: stability attributes may not be used
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

WARNING should be ERROR here, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, fixed.

@alexcrichton
Copy link
Member

@bors: r+ bb407b1 p=1

@bors
Copy link
Contributor

bors commented Apr 21, 2015

⌛ Testing commit bb407b1 with merge 3860240...

bors added a commit that referenced this pull request Apr 21, 2015
@bors bors merged commit bb407b1 into rust-lang:master Apr 21, 2015
@brson
Copy link
Contributor Author

brson commented Apr 23, 2015

(breaking change)

@pnkfelix
Copy link
Member

going from nominated to (nominated, accepted), asap.

@pnkfelix pnkfelix added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Apr 23, 2015
@alexcrichton alexcrichton removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Apr 23, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beta-accepted Accepted for backporting to the compiler in the beta channel.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants