Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove more deprecated functionality #24636

Merged
merged 5 commits into from
Apr 22, 2015
Merged

Remove more deprecated functionality #24636

merged 5 commits into from
Apr 22, 2015

Conversation

alexcrichton
Copy link
Member

This removes a large amount of deprecated functionality (pre-1.0 beta). Mostly this cleans up std::num.

@rust-highfive
Copy link
Collaborator

r? @brson

(rust_highfive has picked a reviewer for you, use r? to override)

@brson brson added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Apr 20, 2015
@brson
Copy link
Contributor

brson commented Apr 20, 2015

I tagged this with 'beta' so we don't forget this needs to go in.

@brson
Copy link
Contributor

brson commented Apr 20, 2015

@bors r+

@bors
Copy link
Contributor

bors commented Apr 20, 2015

📌 Commit cdaf880 has been approved by brson

tamird
tamird reviewed Apr 20, 2015
View reviewed changes
src/libcoretest/num/mod.rs
assert_eq!(s, None);
let f : Option<f32> = from_str_radix("10000000000000000000000000000000000000000", 10).ok();
let f : Option<f32> = f32::from_str_radix("10000000000000000000000000000000000000000", 10).ok();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this failed tidy

@bors
Copy link
Contributor

bors commented Apr 21, 2015

☔ The latest upstream changes (presumably #24648) made this pull request unmergeable. Please resolve the merge conflicts.

@alexcrichton alexcrichton force-pushed the remove-deprecated branch 2 times, most recently from c1da532 to 92369da Compare April 21, 2015 05:26
@alexcrichton
Copy link
Member Author

@bors: r=brson 92369da p=1

@bors
Copy link
Contributor

bors commented Apr 21, 2015

⌛ Testing commit 92369da with merge 1860461...

@bors
Copy link
Contributor

bors commented Apr 21, 2015

💔 Test failed - auto-linux-32-opt

@bors
Copy link
Contributor

bors commented Apr 21, 2015

☔ The latest upstream changes (presumably #24620) made this pull request unmergeable. Please resolve the merge conflicts.

@alexcrichton
std: Remove deprecated AsOsStr/Str/AsSlice traits
69ded69 
Cleaning out more deprecated items
@alexcrichton
std: Remove deprecated AsPath trait
e091ba3
@alexcrichton
std: Remove deprecated/unstable num functionality
eeb9488 
This commit removes all the old casting/generic traits from `std::num` that are
no longer in use by the standard library. This additionally removes the old
`strconv` module which has not seen much use in quite a long time. All generic
functionality has been supplanted with traits in the `num` crate and the
`strconv` module is supplanted with the [rust-strconv crate][rust-strconv].

[rust-strconv]: https://github.com/lifthrasiir/rust-strconv

This is a breaking change due to the removal of these deprecated crates, and the
alternative crates are listed above.

[breaking-change]
@alexcrichton
test: Fix fallout in tests
0791f9f
@alexcrichton alexcrichton force-pushed the remove-deprecated branch 2 times, most recently from 3e5a4af to 41dddce Compare April 21, 2015 18:38
@alexcrichton
Copy link
Member Author

@bors: r=brson 41dddce

@bors
Copy link
Contributor

bors commented Apr 21, 2015

⌛ Testing commit 41dddce with merge db958b7...

@bors
Copy link
Contributor

bors commented Apr 21, 2015

💔 Test failed - auto-win-64-nopt-t

@alexcrichton
Copy link
Member Author

@bors: r+

On Tue, Apr 21, 2015 at 12:54 PM, bors [email protected] wrote:

[image: 💔] Test failed - auto-win-64-nopt-t
http://buildbot.rust-lang.org/builders/auto-win-64-nopt-t/builds/3105

—
Reply to this email directly or view it on GitHub
#24636 (comment).

@bors
Copy link
Contributor

bors commented Apr 21, 2015

📌 Commit 1a10133 has been approved by alexcrichton

@bors
Copy link
Contributor

bors commented Apr 21, 2015

⌛ Testing commit 1a10133 with merge 09e67cf...

@bors
Copy link
Contributor

bors commented Apr 21, 2015

💔 Test failed - auto-win-64-nopt-t

@alexcrichton
Copy link
Member Author

@bors: r+ 028aaaa

@alexcrichton alexcrichton force-pushed the remove-deprecated branch 2 times, most recently from 8f0650e to 1a19c78 Compare April 21, 2015 22:23
@alexcrichton
std: Bring back f32::from_str_radix as an unstable API
a568a7f 
This API was exercised in a few tests and mirrors the `from_str_radix`
functionality of the integer types.
@alexcrichton
Copy link
Member Author

@bors: r+ a568a7f

alexcrichton added a commit to alexcrichton/rust that referenced this pull request Apr 21, 2015
@alexcrichton
rollup merge of rust-lang#24636: alexcrichton/remove-deprecated
a1dd5ac 
Conflicts:
	src/libcore/result.rs
@bors bors merged commit a568a7f into rust-lang:master Apr 22, 2015
This was referenced Apr 22, 2015
Closed
Merged
@pnkfelix
Copy link
Member

going from nominated to (nominated, accepted)

@pnkfelix pnkfelix added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Apr 23, 2015
@alexcrichton alexcrichton removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Apr 23, 2015
@alexcrichton alexcrichton deleted the remove-deprecated branch April 30, 2015 02:12
@cuviper cuviper mentioned this pull request Dec 21, 2017
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@brson brson

Labels
beta-accepted Accepted for backporting to the compiler in the beta channel.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@alexcrichton @rust-highfive @brson @bors @pnkfelix @tamird