std: Add Default/IntoIterator/ToOwned to the prelude #24541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @aturon |
|
(rust_highfive has picked a reviewer for you, use r? to override) |
alexcrichton
force-pushed
the
issue-24538
branch
2 times, most recently
from
ad96559
to
38decbc
Compare
This is an implementation of [RFC 1030][rfc] which adds these traits to the prelude and additionally removes all inherent `into_iter` methods on collections in favor of the trait implementation (which is now accessible by default). [rfc]: rust-lang/rfcs#1030 This is technically a breaking change due to the prelude additions and removal of inherent methods, but it is expected that essentially no code breaks in practice. [breaking-change] Closes rust-lang#24538
alexcrichton
force-pushed
the
issue-24538
branch
from
38decbc
to
8f5b5f9
Compare
|
@bors: r+ p=10 |
|
📌 Commit 8f5b5f9 has been approved by |
aturon
added
the
beta-nominated
|
Nominating for beta inclusion. |
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Apr 21, 2015
This is an implementation of [RFC 1030][rfc] which adds these traits to the prelude and additionally removes all inherent `into_iter` methods on collections in favor of the trait implementation (which is now accessible by default). [rfc]: rust-lang/rfcs#1030 This is technically a breaking change due to the prelude additions and removal of inherent methods, but it is expected that essentially no code breaks in practice. [breaking-change] Closes rust-lang#24538
|
⌛ Testing commit 8f5b5f9 with merge 0ff9888... |
|
⛄ The build was interrupted to prioritize another pull request. |
|
⌛ Testing commit 8f5b5f9 with merge 977b6fd... |
|
⛄ The build was interrupted to prioritize another pull request. |
|
(special-casing for 1.0; i.e. a "minor" change like this would not normally go into beta, though of course it is a breaking change b/c of prelude and thus we are accepting it for beta.) going from nominated to (nominated, accepted) |
pnkfelix
added
the
beta-accepted
alexcrichton
removed
the
beta-nominated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an implementation of RFC 1030 which adds these traits to the
prelude and additionally removes all inherent
into_itermethods on collectionsin favor of the trait implementation (which is now accessible by default).
This is technically a breaking change due to the prelude additions and removal
of inherent methods, but it is expected that essentially no code breaks in
practice.
[breaking-change]
Closes #24538