Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove one allocation for the file path in file opening #24452

Merged
merged 1 commit into from
Apr 17, 2015
Merged

Remove one allocation for the file path in file opening #24452

merged 1 commit into from
Apr 17, 2015

Conversation

tbu-
Copy link
Contributor

@tbu- tbu- commented Apr 15, 2015

Fixes #22190.

@rust-highfive
Copy link
Collaborator

r? @huonw

(rust_highfive has picked a reviewer for you, use r? to override)

@huonw
Copy link
Member

huonw commented Apr 15, 2015

r? @aturon (has a better idea of the tradeoffs here.)

@rust-highfive rust-highfive assigned aturon and unassigned huonw Apr 15, 2015
@alexcrichton
Copy link
Member

I think this is definitely more in-line with today's I/O primitives and paradigms, so I'm ok with this change.

@aturon
Copy link
Member

aturon commented Apr 15, 2015

Yes, this is the direction we wanted to head in. old_io used this path for error messages, but that behavior wasn't carried over anyway.

@bors: r+

@bors
Copy link
Contributor

bors commented Apr 15, 2015

📌 Commit 53b7a06 has been approved by aturon

@Manishearth
Copy link
Member

Needs Manishearth@aa05130 to compile

Manishearth added a commit to Manishearth/rust that referenced this pull request Apr 17, 2015
@Manishearth
Rollup merge of rust-lang#24452 - tbu-:pr_file_path, r=aturon
846ec31 
 Fixes rust-lang#22190.
Manishearth added a commit to Manishearth/rust that referenced this pull request Apr 17, 2015
@Manishearth
Remove info for path (fixup rust-lang#24452)
8df397d
Manishearth added a commit to Manishearth/rust that referenced this pull request Apr 17, 2015
@Manishearth
Rollup merge of rust-lang#24452 - tbu-:pr_file_path, r=aturon
3118cd7 
 Fixes rust-lang#22190.
Manishearth added a commit to Manishearth/rust that referenced this pull request Apr 17, 2015
@Manishearth
Remove info for path (fixup rust-lang#24452)
c98115c
@tbu-
Copy link
Contributor Author

tbu- commented Apr 17, 2015

@Manishearth Sorry for the inconvenience and thanks for fixing my patch.

@bors
Copy link
Contributor

bors commented Apr 17, 2015

⌛ Testing commit 53b7a06 with merge ca8807a...

@bors
Copy link
Contributor

bors commented Apr 17, 2015

💔 Test failed - auto-mac-64-nopt-t

@alexcrichton
Copy link
Member

@bors: retry

On Fri, Apr 17, 2015 at 8:20 AM, bors [email protected] wrote:

[image: 💔] Test failed - auto-mac-64-nopt-t
http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-t/builds/4567

—
Reply to this email directly or view it on GitHub
#24452 (comment).

@bors bors merged commit 53b7a06 into rust-lang:master Apr 17, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@aturon aturon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

It's not possible to open a file without invoking allocations for the file name
7 participants
@tbu- @rust-highfive @huonw @alexcrichton @aturon @bors @Manishearth