Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disabling jemalloc on bitrig #23255

Merged
merged 2 commits into from
Mar 12, 2015
Merged

disabling jemalloc on bitrig #23255

merged 2 commits into from
Mar 12, 2015

Conversation

dhuseby
Copy link

@dhuseby dhuseby commented Mar 10, 2015

it turns out that jemalloc doesn't behave well on bitrig. with jemalloc enabled i get some kernel errors related to sbrk failures. with jemalloc disabled, the errors go away. i am investigating, but in the mean time, we should just disable jemalloc by default on bitrig.

@rust-highfive
Copy link
Collaborator

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@nikomatsakis
Copy link
Contributor

@bors r+ 074f094 rollup

@dhuseby
Copy link
Author

dhuseby commented Mar 10, 2015

While compiling Rust from source on Bitrig using a Rust snapshot built with jemalloc enabled, I get a lot of errors that look like this:

sbrk: grow 12850741248 failed, error = 12
sbrk: grow 8743018496 failed, error = 12
sbrk: grow 12560965632 failed, error = 12
sbrk: grow 12030480384 failed, error = 12
sbrk: grow 9737023488 failed, error = 12
sbrk: grow 11791466496 failed, error = 12
sbrk: grow 11408199680 failed, error = 12
sbrk: grow 10830114816 failed, error = 12
sbrk: grow 10409455616 failed, error = 12
sbrk: grow 9631027200 failed, error = 12
sbrk: grow 10049781760 failed, error = 12

It doesn't seem to affect Rust functionality but it sure looks scary. Like I said, I'm disabling jemalloc on Bitrig until I know what is causing this and I upstream the patches to jemalloc.

@semarie
Copy link
Contributor

semarie commented Mar 10, 2015

@dhuseby I don't known if it is related, but under openbsd I use the following patch https://github.com/jasperla/openbsd-wip/blob/master/lang/rustc/patches/patch-src_jemalloc_configure for building jemalloc.

The latest version of jemalloc proper detect the lake of tls (thread-local-storage), but not the version used by rust.

I hope this could help you.

@dhuseby
Copy link
Author

dhuseby commented Mar 10, 2015

@semarie that might fix the problem. i'll give it a try soon. i did notice that without jemalloc, several of my test apps ran noticeably (wall clock) faster. But that may have been because jemalloc was broken.

@dhuseby
Copy link
Author

dhuseby commented Mar 10, 2015

@nikomatsakis sorry for confusing things a bit, a new snapshot for bitrig was just uploaded and i added it to the snapshots.txt file and bumped llvm-auto-clean-trigger too.

@dhuseby
Copy link
Author

dhuseby commented Mar 10, 2015

@nikomatsakis both disabling jemalloc and the new snapshot are needed to get the bitrig buildbot working properly.

@alexcrichton
Copy link
Member

You should be able to leave out the llvm-auto-clean-trigger modification as this PR didn't change LLVM itself (so it shouldn't need to be rebuilt)

@dhuseby
Copy link
Author

dhuseby commented Mar 10, 2015

@alexcrichton aha! ok, I see.

@dhuseby
Copy link
Author

dhuseby commented Mar 10, 2015

OK, I reverted the bump in llvm-auto-clean-trigger and rebased to the current master HEAD.

@alexcrichton
Copy link
Member

Could you peel off the last two commits as well? Otherwise r=me, thanks!

@dhuseby
Copy link
Author

dhuseby commented Mar 10, 2015

@alexcrichton sure

@alexcrichton
Copy link
Member

@bors: r+ c005f8a2f1022679ab3fb4353e12cc795f04a9a0

@@ -1,4 +1,5 @@
S 2015-03-07 270a677
birig-x86_64 4b2f11a96b1b5b3782d74bda707aca33bc179880
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the name is invalid: it should be bitrig (missing t)

@dhuseby
Copy link
Author

dhuseby commented Mar 11, 2015

@semarie good catch! corrected.

@dhuseby
Copy link
Author

dhuseby commented Mar 11, 2015

rebased to current master HEAD.

@alexcrichton
Copy link
Member

@bors: r+ 33751ff

Manishearth added a commit to Manishearth/rust that referenced this pull request Mar 12, 2015
 it turns out that jemalloc doesn't behave well on bitrig.  with jemalloc enabled i get some kernel errors related to sbrk failures.  with jemalloc disabled, the errors go away.  i am investigating, but in the mean time, we should just disable jemalloc by default on bitrig.
@bors bors merged commit 33751ff into rust-lang:master Mar 12, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants