Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

std: Remove #[allow] directives in sys modules #23245

Merged
merged 1 commit into from
Mar 12, 2015
Merged

std: Remove #[allow] directives in sys modules #23245

merged 1 commit into from
Mar 12, 2015

Conversation

alexcrichton
Copy link
Member

These were suppressing lots of interesting warnings! Turns out there was also
quite a bit of dead code.

@rust-highfive
Copy link
Collaborator

r? @aturon

(rust_highfive has picked a reviewer for you, use r? to override)

@aturon
Copy link
Member

aturon commented Mar 10, 2015

Nice!

@bors: r+ 2dbf199

@bors
Copy link
Contributor

bors commented Mar 10, 2015

⌛ Testing commit 2dbf199 with merge c4c308b...

@bors
Copy link
Contributor

bors commented Mar 10, 2015

💔 Test failed - auto-mac-32-opt

@alexcrichton
Copy link
Member Author

@bors: r=aturon

@bors
Copy link
Contributor

bors commented Mar 10, 2015

@bors r=aturon b96ecbf

@alexcrichton alexcrichton mentioned this pull request Mar 11, 2015
Merged
@bors
Copy link
Contributor

bors commented Mar 11, 2015

⌛ Testing commit b96ecbf with merge a190f0d...

@bors
Copy link
Contributor

bors commented Mar 11, 2015

💔 Test failed - auto-mac-32-opt

Manishearth added a commit to Manishearth/rust that referenced this pull request Mar 11, 2015
@Manishearth
Rollup merge of rust-lang#23267 - alexcrichton:issue-20012, r=brson
ec8d61d 
 This reverts commit aec67c2.

Closes rust-lang#20012

This is temporarily rebased on rust-lang#23245 as it would otherwise conflict, the last commit is the only one relevant to this PR though.
@Manishearth
Copy link
Member 

/Users/rustbuild/src/rust-buildbot/slave/auto-mac-32-opt/build/src/libstd/sys/unix/backtrace.rs:87:5: 87:26 error: unused import, #[deny(unused_imports)] on by default
/Users/rustbuild/src/rust-buildbot/slave/auto-mac-32-opt/build/src/libstd/sys/unix/backtrace.rs:87 use os::unix::prelude::*;
                                                                                                       ^~~~~~~~~~~~~~~~~~~~~
error: aborting due to previous error
make: *** [i686-apple-darwin/stage1/lib/rustlib/i686-apple-darwin/lib/stamp.std] Error 101

@alexcrichton
Copy link
Member Author

@bors: r=aturon 7ccd8bc

@Manishearth
Copy link
Member

Might have caused this?

/Users/rustbuild/src/rust-buildbot/slave/auto-mac-64-nopt-t/build/src/libstd/sys/unix/backtrace.rs:87:5: 87:26 error: unused import, #[deny(unused_imports)] on by default
/Users/rustbuild/src/rust-buildbot/slave/auto-mac-64-nopt-t/build/src/libstd/sys/unix/backtrace.rs:87 use os::unix::prelude::*;
                                                                                                          ^~~~~~~~~~~~~~~~~~~~~
/Users/rustbuild/src/rust-buildbot/slave/auto-mac-64-nopt-t/build/src/libstd/sys/unix/backtrace.rs:89:17: 89:24 error: unused import, #[deny(unused_imports)] on by default
/Users/rustbuild/src/rust-buildbot/slave/auto-mac-64-nopt-t/build/src/libstd/sys/unix/backtrace.rs:89 use ffi::{CStr, AsOsStr};
                                                                                                                      ^~~~~~~
/Users/rustbuild/src/rust-buildbot/slave/auto-mac-64-nopt-t/build/src/libstd/sys/unix/time.rs:61:13: 65:14 error: unnecessary `unsafe` block, #[deny(unused_unsafe)] on by default
/Users/rustbuild/src/rust-buildbot/slave/auto-mac-64-nopt-t/build/src/libstd/sys/unix/time.rs:61             unsafe {
/Users/rustbuild/src/rust-buildbot/slave/auto-mac-64-nopt-t/build/src/libstd/sys/unix/time.rs:62                 let info = info();
/Users/rustbuild/src/rust-buildbot/slave/auto-mac-64-nopt-t/build/src/libstd/sys/unix/time.rs:63                 let diff = self.t as i64 - other.t as i64;
/Users/rustbuild/src/rust-buildbot/slave/auto-mac-64-nopt-t/build/src/libstd/sys/unix/time.rs:64                 Duration::nanoseconds(diff * info.numer as i64 / info.denom as i64)
/Users/rustbuild/src/rust-buildbot/slave/auto-mac-64-nopt-t/build/src/libstd/sys/unix/time.rs:65             }
error: aborting due to 3 previous errors

http://buildbot.rust-lang.org/builders/auto-mac-64-nopt-t/builds/4049/steps/compile/logs/stdio

@bors
Copy link
Contributor

bors commented Mar 12, 2015

⌛ Testing commit 7ccd8bc with merge 38d442c...

@bors
Copy link
Contributor

bors commented Mar 12, 2015

💔 Test failed - auto-linux-64-x-android-t

@Manishearth
Copy link
Member 

/home/rustbuild/src/rust-buildbot/slave/auto-linux-64-x-android-t/build/src/libstd/sys/unix/thread.rs:337:9: 338:79 error: foreign function is never used: `pthread_getattr_np`, #[deny(dead_code)] on by default
/home/rustbuild/src/rust-buildbot/slave/auto-linux-64-x-android-t/build/src/libstd/sys/unix/thread.rs:337     pub fn pthread_getattr_np(native: libc::pthread_t,
/home/rustbuild/src/rust-buildbot/slave/auto-linux-64-x-android-t/build/src/libstd/sys/unix/thread.rs:338                               attr: *mut libc::pthread_attr_t) -> libc::c_int;
/home/rustbuild/src/rust-buildbot/slave/auto-linux-64-x-android-t/build/src/libstd/sys/unix/thread.rs:339:9: 340:83 error: foreign function is never used: `pthread_attr_getguardsize`, #[deny(dead_code)] on by default
/home/rustbuild/src/rust-buildbot/slave/auto-linux-64-x-android-t/build/src/libstd/sys/unix/thread.rs:339     pub fn pthread_attr_getguardsize(attr: *const libc::pthread_attr_t,
/home/rustbuild/src/rust-buildbot/slave/auto-linux-64-x-android-t/build/src/libstd/sys/unix/thread.rs:340                                      guardsize: *mut libc::size_t) -> libc::c_int;
/home/rustbuild/src/rust-buildbot/slave/auto-linux-64-x-android-t/build/src/libstd/sys/unix/thread.rs:341:9: 343:79 error: foreign function is never used: `pthread_attr_getstack`, #[deny(dead_code)] on by default
/home/rustbuild/src/rust-buildbot/slave/auto-linux-64-x-android-t/build/src/libstd/sys/unix/thread.rs:341     pub fn pthread_attr_getstack(attr: *const libc::pthread_attr_t,
/home/rustbuild/src/rust-buildbot/slave/auto-linux-64-x-android-t/build/src/libstd/sys/unix/thread.rs:342                                  stackaddr: *mut *mut libc::c_void,
/home/rustbuild/src/rust-buildbot/slave/auto-linux-64-x-android-t/build/src/libstd/sys/unix/thread.rs:343                                  stacksize: *mut libc::size_t) -> libc::c_int;
error: aborting due to 3 previous errors

@alexcrichton
std: Remove #[allow] directives in sys modules
c933d44 
These were suppressing lots of interesting warnings! Turns out there was also
quite a bit of dead code.
@alexcrichton
Copy link
Member Author

@bors: r=aturon c933d44

bors added a commit that referenced this pull request Mar 12, 2015
@bors
Auto merge of #23245 - alexcrichton:allow-warnings-again, r=aturon
538840b 
These were suppressing lots of interesting warnings! Turns out there was also
quite a bit of dead code.
@bors
Copy link
Contributor

bors commented Mar 12, 2015

⌛ Testing commit c933d44 with merge 538840b...

@bors
Copy link
Contributor

bors commented Mar 12, 2015

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-x-android-t, auto-mac-32-opt, auto-mac-64-nopt-t, auto-mac-64-opt, auto-win-32-nopt-t, auto-win-32-opt, auto-win-64-nopt-t, auto-win-64-opt

@bors bors merged commit c933d44 into rust-lang:master Mar 12, 2015
This was referenced Mar 12, 2015
Merged
Merged
Merged
bors added a commit that referenced this pull request Mar 13, 2015
@bors
Auto merge of #23267 - alexcrichton:issue-20012, r=aturon
4a5101a 
This reverts commit aec67c2.

Closes #20012

This is temporarily rebased on #23245 as it would otherwise conflict, the last commit is the only one relevant to this PR though.
bors added a commit that referenced this pull request Mar 20, 2015
@bors
Auto merge of #23267 - alexcrichton:issue-20012, r=aturon
68d6941 
This reverts commit aec67c2.

Closes #20012

This is temporarily rebased on #23245 as it would otherwise conflict, the last commit is the only one relevant to this PR though.
@alexcrichton alexcrichton deleted the allow-warnings-again branch March 27, 2015 20:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@aturon aturon

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@alexcrichton @rust-highfive @aturon @bors @Manishearth