iter: merge Cloned and Inspect into Map #23062
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code of the Map, Cloned and Inspect are the same except the name and the mapping call. Signed-off-by: Lai Jiangshan <[email protected]>
|
r? @aturon (rust_highfive has picked a reviewer for you, use r? to override) |
| @@ -1273,60 +1269,21 @@ impl<T: Clone> MinMaxResult<T> { | |||
| /// An iterator that clones the elements of an underlying iterator | |||
| #[unstable(feature = "core", reason = "recent addition")] | |||
| #[must_use = "iterator adaptors are lazy and do nothing unless consumed"] | |||
| #[derive(Clone)] | |||
| pub struct Cloned<I> { | |||
There was a problem hiding this comment.
Using a newtype structure which is opaque to its contents is an intentional decision on behalf of std::iter. It allows us to flexibly change the representation in the future if necessary.
There was a problem hiding this comment.
(same for Inspect down below)
|
☔ The latest upstream changes (presumably #23107) made this pull request unmergeable. Please resolve the merge conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code of the Map, Cloned and Inspect are the same except the name
and the mapping call.
Signed-off-by: Lai Jiangshan [email protected]