Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove int/uint in libcore/lib.rs #22504

Merged
merged 3 commits into from
Mar 2, 2015
Merged

Remove int/uint in libcore/lib.rs #22504

merged 3 commits into from
Mar 2, 2015

Conversation

GuillaumeGomez
Copy link
Member

Part of #22240.

@rust-highfive
Copy link
Collaborator

r? @huonw

(rust_highfive has picked a reviewer for you, use r? to override)

@GuillaumeGomez GuillaumeGomez changed the title Remove int/uint Remove int/uint in libcore/lib.rs Feb 18, 2015
@aturon
Copy link
Member

aturon commented Feb 18, 2015

The actual file defining the module should be removed as well.

@GuillaumeGomez
Copy link
Member Author

Since the last commit does the exact same thing as #22503, I think we can close #22503.

GuillaumeGomez
GuillaumeGomez reviewed Feb 19, 2015
View reviewed changes
src/librand/rand_impls.rs
} else {
rng.gen::<i64>() as int
rng.gen::<i64>() as isize
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@aturon: I kept the same logic, but I'm not sure it's correct. What's your opinion on this ?

@GuillaumeGomez GuillaumeGomez mentioned this pull request Feb 19, 2015
Closed
@GuillaumeGomez
Copy link
Member Author

@aturon ? Your opinion here please ?

@alexcrichton
Copy link
Member

@bors: r+ 6a9db02

@alexcrichton
Copy link
Member

@bors: r-

Er actually the pub use isize as int; annotations in libstd/lib.rs also need to be removed I believe.

@GuillaumeGomez
Copy link
Member Author

Done !

@alexcrichton
Copy link
Member

(forgot a push?)

@GuillaumeGomez
Copy link
Member Author

My last commit did or maybe I misunderstood you... What line where you talking about ?

@dotdash
Copy link
Contributor

dotdash commented Feb 27, 2015

@alexcrichton for some reason github displays the new commit above your r+ comment, although it is newer than that

@alexcrichton
Copy link
Member

@bors: r+ 1e71f51a675c39e8d233b104d6cd344c277f4af0

@bors
Copy link
Contributor

bors commented Feb 27, 2015

⌛ Testing commit 1e71f51 with merge 222e372...

@bors
Copy link
Contributor

bors commented Feb 27, 2015

💔 Test failed - auto-linux-64-x-android-t

@alexcrichton
Copy link
Member

@bors: retry

@bors
Copy link
Contributor

bors commented Feb 27, 2015

⚡ Previous build results are reusable. Rebuilding only auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-x-android-t, auto-mac-32-opt, auto-mac-64-nopt-t, auto-mac-64-opt, auto-win-32-nopt-t, auto-win-32-opt, auto-win-64-nopt-t, auto-win-64-opt...

@bors
Copy link
Contributor

bors commented Feb 27, 2015

💔 Test failed - auto-mac-32-opt

@bors
Copy link
Contributor

bors commented Feb 27, 2015

💔 Test failed - auto-win-64-nopt-t

@alexcrichton
Copy link
Member

@bors: retry clean

@bors
Copy link
Contributor

bors commented Feb 27, 2015

⌛ Testing commit 1e71f51 with merge 19c294a...

@bors
Copy link
Contributor

bors commented Feb 27, 2015

💔 Test failed - auto-linux-64-nopt-t

@alexcrichton
Copy link
Member

@bors: retry clean

@alexcrichton
Copy link
Member

@bors: rollup

@Manishearth
Copy link
Member

This one fails tests from libcoretest :/

Please run a make check-stage1, at least make check-stage1-crates. It's hard to fix up pull requests that break unit tests since they trigger a full rebuild.

@Manishearth
Copy link
Member

@bors: r-

@huonw huonw assigned alexcrichton and unassigned huonw Mar 1, 2015
@GuillaumeGomez
Copy link
Member Author

I fixed tests. @alexcrichton @Manishearth

@Manishearth
Copy link
Member

@bors: rollup r=alexcrichton

@bors
Copy link
Contributor

bors commented Mar 1, 2015

@bors r=Manishearth df12658

Manishearth added a commit to Manishearth/rust that referenced this pull request Mar 1, 2015
@Manishearth
Rollup merge of rust-lang#22504 - GuillaumeGomez:audit-integer-libcor…
fb19cd7 
…e, r=Manishearth

 Part of rust-lang#22240.
@bors bors merged commit df12658 into rust-lang:master Mar 2, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@alexcrichton alexcrichton

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@GuillaumeGomez @rust-highfive @aturon @alexcrichton @dotdash @bors @Manishearth @huonw