-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
deprecate --help -v #22495
deprecate --help -v #22495
Conversation
the verbose option to help shows only a few extra lines, so just show them all by default and save some time and keystrokes
r? @huonw (rust_highfive has picked a reviewer for you, use r? to override) |
While there are not particularly many more options in |
Sure. I guess the counterargument is that it's a fairly bizarre feature, especially when it masks some interesting options, eg if I wanted to know how to uncolor the output the first thing I would try would be
My intuition is that this should be removed, and reconsidered if the help text is getting out of control. I'm pretty sure that a middleground solution, like leaving all the plumbing around, but still showing the whole help message is the worst outcome. As it stands, the verbose output is only 49 lines. |
I'm pretty neutral on this issue. I have sympathy for both arguments, but I think that hiding arguments might be more annoying than having lots of output in the long run. |
r? @alexcrichton (reassigning, also ping) |
ping? |
☔ The latest upstream changes (presumably #23298) made this pull request unmergeable. Please resolve the merge conflicts. |
Is it worth me rebasing this? |
I'm with @alexcrichton ; I think the situation now is a better foundation for the future than unifying the two. |
Heh, my feelings are mixed too. I think the current design is definitely a surprise, since it's uncommon, but compilers have bazillions of options, and keeping them organized is a noble goal. My inclination is to stick with the status quo, and revisit later if it continues to be an issue. I'll take the liberty of closing. Thanks @richo. |
the verbose option to help shows only a few extra lines, so just show
them all by default and save some time and keystrokes
The diff that
-v
introduced on the output ofrustc --help
was only: