std: Stabilize FromStr and parse #21718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @aturon |
|
r? @huonw (rust_highfive has picked a reviewer for you, use r? to override) |
alexcrichton
force-pushed
the
stabilize-from-str
branch
3 times, most recently
from
0e52a3b
to
e17518f
Compare
alexcrichton
force-pushed
the
stabilize-from-str
branch
4 times, most recently
from
7f2f201
to
79b79b5
Compare
This commits adds an associated type to the `FromStr` trait representing an error payload for parses which do not succeed. The previous return value, `Option<Self>` did not allow for this form of payload. After the associated type was added, the following attributes were applied: * `FromStr` is now stable * `FromStr::Err` is now stable * `FromStr::from_str` is now stable * `StrExt::parse` is now stable * `FromStr for bool` is now stable * `FromStr for $float` is now stable * `FromStr for $integral` is now stable * Errors returned from stable `FromStr` implementations are stable * Errors implement `Display` and `Error` (both impl blocks being `#[stable]`) Closes rust-lang#15138
alexcrichton
force-pushed
the
stabilize-from-str
branch
from
79b79b5
to
0cdde6e
Compare
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Jan 30, 2015
This commits adds an associated type to the `FromStr` trait representing an error payload for parses which do not succeed. The previous return value, `Option<Self>` did not allow for this form of payload. After the associated type was added, the following attributes were applied: * `FromStr` is now stable * `FromStr::Err` is now stable * `FromStr::from_str` is now stable * `StrExt::parse` is now stable * `FromStr for bool` is now stable * `FromStr for $float` is now stable * `FromStr for $integral` is now stable * Errors returned from stable `FromStr` implementations are stable * Errors implement `Display` and `Error` (both impl blocks being `#[stable]`) Closes rust-lang#15138
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Feb 4, 2015
These were forgotten reexports from rust-lang#21718 Closes rust-lang#21929
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commits adds an associated type to the
FromStrtrait representing anerror payload for parses which do not succeed. The previous return value,
Option<Self>did not allow for this form of payload. After the associated typewas added, the following attributes were applied:
FromStris now stableFromStr::Erris now stableFromStr::from_stris now stableStrExt::parseis now stableFromStr for boolis now stableFromStr for $floatis now stableFromStr for $integralis now stableFromStrimplementations are stableDisplayandError(both impl blocks being#[stable])Closes #15138