Handle range in model lexer correctly #15877 #20310
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @huonw (rust_highfive has picked a reviewer for you, use r? to override) |
|
r? @cmr |
|
This is an extremely unfortunate aspect of our lexical syntax... |
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Dec 30, 2014
This patch for rust-lang#15877 uses Antlr's input lookahead (`_input.LA(1) != '.'`) to solve the conflict between the LIT_FLOAT and the range syntax. Note that in order to execute the grammar tests, rust-lang#20245 should land first.
|
@fhahn Woo! I'm glad somebody is maintaining this. I swear we will start regression testing it at some point. |
|
I think at the moment, about 30-40 lexer tests are still failing. I think most problems should be covered by the issues mentioned in #15883. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch for #15877 uses Antlr's input lookahead (
_input.LA(1) != '.') to solve the conflict between the LIT_FLOAT and the range syntax.Note that in order to execute the grammar tests, #20245 should land first.