-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kill TreeMap, TreeSet, TrieMap, TrieSet, LruCache and EnumSet #19955
Conversation
This looks great, thanks @gankro! |
@gankro r=me after rebase/squash |
9e9768a
to
7cb02a7
Compare
7cb02a7
to
67d3823
Compare
EnumSet lives on in libcollections so that librustc can still use it. This adds a direct dependency on libcollections to librustc and libserialize. Should not be merged until rust-lang/rfcs#509 is accepted. All of these collections have already been moved to collect-rs where they will ideally be maintained and experimented with, or will be replaced by something better: https://github.com/Gankro/collect-rs/ [breaking-change] r? @aturon @alexcrichton
@gankro You write "Kill |
@tbu- It's not in std anymore; only libcollections. |
Hmm I think this PR accidentally destroyed the special rust/src/test/run-pass/issue-16278.rs Lines 15 to 17 in 74ae05a
This breaks the regression testing that we would want for #16278 (I only happened to notice their absence because I was wondering why this file was listed here:) rust/src/test/run-pass/.gitattributes Line 2 in f17c230
|
…278, r=wesleywiser Recover proper regression test for issue rust-lang#16278. Spawned from my note rust-lang#19955 (comment)
EnumSet lives on in libcollections so that librustc can still use it. This adds a direct dependency on libcollections to librustc and libserialize.
Should not be merged until rust-lang/rfcs#509 is accepted.
All of these collections have already been moved to collect-rs where they will ideally be maintained and experimented with, or will be replaced by something better: https://github.com/Gankro/collect-rs/[breaking-change]
r? @aturon @alexcrichton