Add RingBuf::as_slices as per collections reform v2. #19903
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -76,7 +76,13 @@ impl<T> Default for RingBuf<T> { | |||
| impl<T> RingBuf<T> { | |||
| /// Turn ptr into a slice | |||
| #[inline] | |||
| unsafe fn buffer_as_slice(&self) -> &[T] { | |||
| unsafe fn buffer_as_slice<'a>(&'a self) -> &'a [T] { | |||
There was a problem hiding this comment.
It's implemented with transmute with no lifetime annotations. It seems safer this way.
There was a problem hiding this comment.
Mmm... sweet, sweet elision paranoia. :)
|
Let's please hold off merging this until rust-lang/rfcs#509 is merged as well (but review is fine!) |
|
RFC 509 has landed. Let's merge this sucker! |
| let expected_right: Vec<_> = range(cap+1, cap+2).collect(); | ||
| assert_eq!(left, expected_left); | ||
| assert_eq!(right, expected_right); | ||
| } |
There was a problem hiding this comment.
Actually, it occurs to me: can't you make this test capacity agnostic by just doing push_back()x2, push_front()x2? Or are you testing some particular edge cases?
|
This LGTM now. r=me whether you change the test or not; your call on which way you prefer. |
See: rust-lang/rfcs#509 Not sure if this is allowed to land before the RFC. Either way, it's here for review. r? @gankro cc: @bfops
cgaebel
force-pushed
the
ringbuf-as-slice
branch
from
69c60c2
to
525f65e
Compare
|
|
bors
added a commit
that referenced
this pull request
Dec 20, 2014
See: rust-lang/rfcs#509 Not sure if this is allowed to land before the RFC. Either way, it's here for review. r? @gankro cc: @bfops
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: rust-lang/rfcs#509
Not sure if this is allowed to land before the RFC. Either way,
it's here for review.
r? @gankro
cc: @bfops