Unpublicize JSON reexports, unprefix JSON type aliases #19224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @aturon |
|
Can you make sure to word the commit message in accordance with our breaking changes policy? This seems ok to me, cc #19253. |
|
@alexcrichton Ah, was not aware of that policy. Will rename now |
|
No worries, thanks @frewsxcv! |
frewsxcv
force-pushed
the
unprefix-json-types
branch
from
9f3b64d
to
5646221
Compare
|
Look alright @alexcrichton ? |
frewsxcv
changed the title
frewsxcv
force-pushed
the
unprefix-json-types
branch
from
5646221
to
482111a
Compare
|
Had a stupid error, fixed it, squashed it |
| Some(U64Value(n)) => Ok(U64(n)), | ||
| Some(F64Value(n)) => Ok(F64(n)), | ||
| Some(BooleanValue(b)) => Ok(Boolean(b)), | ||
| return match self.token { |
The type aliases json::JsonString and json::JsonObject were originally prefixed with 'json' to prevent collisions with (at the time) the enums json::String and json::Object respectively. Now that enum namespacing has landed, this 'json' prefix is redundant and can be removed: json::JsonArray -> json::Array json::JsonObject -> json::Object In addition, this commit also unpublicizes all of the re-exports in this JSON module, as a part of rust-lang#19253 [breaking-change]
frewsxcv
force-pushed
the
unprefix-json-types
branch
from
482111a
to
ce238d7
Compare
|
Okay, more stupid errors. I guess I didn't run the tests last time? Let's hope third times the charm |
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Nov 27, 2014
Addressing the issues brought up in [this thread](rust-lang#19114 (comment)) This pull request: * Unpublicizes reexports * Renames type aliases: * `json::JsonArray` ☞ `json::Array` * `json::JsonObject` ☞ `json::Object`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressing the issues brought up in this thread
This pull request:
json::JsonArray☞json::Arrayjson::JsonObject☞json::Object