librustc: Always parse macro!()/macro![] as expressions if not followed by a semicolon.
#18958
Conversation
pcwalton
changed the title
macro!()/macro![] as expressions if notmacro!()/macro![] as expressions if not followed by a semicolon.
pcwalton
force-pushed
the
macro-expressions
branch
from
6cf007c
to
bf5e242
Compare
|
Really liking this cleanup, thanks @pcwalton! Could you add some tests for ensuring that Other than that, r=me |
|
To quote from the RFC:
Does this pull request handle that? That is, this should require that all macros invoked at the top level (not inside a function or block, which I can see is handled) also must be followed by a semicolon, unless they are invoked with |
pcwalton
force-pushed
the
macro-expressions
branch
2 times, most recently
from
67c1b03
to
b38bbae
Compare
|
Now implements the rules @P1start suggested. This broke a lot of code. re-r? @alexcrichton |
|
Parentheses for you, and you, and you! Another heroic effort by @pcwalton! |
followed by a semicolon.
This allows code like `vec![1i, 2, 3].len();` to work.
This breaks code that uses macros as statements without putting
semicolons after them, such as:
fn main() {
...
assert!(a == b)
assert!(c == d)
println(...);
}
It also breaks code that uses macros as items without semicolons:
local_data_key!(foo)
fn main() {
println("hello world")
}
Add semicolons to fix this code. Those two examples can be fixed as
follows:
fn main() {
...
assert!(a == b);
assert!(c == d);
println(...);
}
local_data_key!(foo);
fn main() {
println("hello world")
}
RFC rust-lang#378.
Closes rust-lang#18635.
[breaking-change]
pcwalton
force-pushed
the
macro-expressions
branch
from
b38bbae
to
6a855f6
Compare
|
This needs rebased by now 😦 |
followed by a semicolon.
This allows code like `vec![1i, 2, 3].len();` to work.
This breaks code that uses macros as statements without putting
semicolons after them, such as:
fn main() {
...
assert!(a == b)
assert!(c == d)
println(...);
}
It also breaks code that uses macros as items without semicolons:
local_data_key!(foo)
fn main() {
println("hello world")
}
Add semicolons to fix this code. Those two examples can be fixed as
follows:
fn main() {
...
assert!(a == b);
assert!(c == d);
println(...);
}
local_data_key!(foo);
fn main() {
println("hello world")
}
RFC #378.
Closes #18635.
[breaking-change]
---
Rebased version of #18958
r? @alexcrichton
cc @pcwalton
|
Closing in favor of #19984 |
This allows code like
vec![1i, 2, 3].len();to work.This breaks code that uses macros as statements without putting
semicolons after them, such as:
It also breaks code that uses macros as items without semicolons:
Add semicolons to fix this code. Those two examples can be fixed as
follows:
RFC #378.
Closes #18635.
[breaking-change]
r? @alexcrichton