Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify Error description and detail should be single line #18629

Closed
wants to merge 1 commit into from

Conversation

stepancheg
Copy link
Contributor

When description and detail are known to be single line, they can
be used like this, and programmer can be sure that message is
formatted nicely.

println!("could not download file: {}, trying again in 5s", e.description());

When description and detail are known to be single line, they can
be used like this, and programmer can be sure that message is
formatted nicely.

```
println!("could not download file: {}, trying again in 5s", e.description());
```
@aturon
Copy link
Member

aturon commented Nov 8, 2014

@stepancheg Thanks for the PR! It does seem like a good idea to standardize on a convention here. I believe this is already followed within IO errors. But I'd like to get a little bit of community feedback before landing this change.

Would you mind either posting this proposal to http://discuss.rust-lang.org/ or as a short conventions RFC?

Thanks again.

@stepancheg
Copy link
Contributor Author

@bstrie
Copy link
Contributor

bstrie commented Nov 20, 2014

I think we should hold off on work like this until we get a chance to do a comprehensive pass on error-handling conventions, rather than working piecemeal on something that may get thrown out entirely for all we know. I know Armin at least thinks that Error might be the wrong way to go in the long term.

@steveklabnik
Copy link
Member

There has been no discussion on Discourse, and there's been some recent talk about changing errors from @mitsuhiko. What should we do with this PR?

@alexcrichton
Copy link
Member

For now I'm going to close this in favor of rust-lang/rfcs#492 to help clear out the queue and take some action on this. Depending on the resolution of that RFC we can reopen this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants