Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cross-crate self as argument method calls #18177

Merged
merged 6 commits into from
Nov 1, 2014
Merged

Cross-crate self as argument method calls #18177

merged 6 commits into from
Nov 1, 2014

Conversation

nrc
Copy link
Member

@nrc nrc commented Oct 20, 2014

r?

closes #18061

@nrc nrc changed the title Cross-crait self as argument method calls Cross-crate self as argument method calls Oct 20, 2014
@nrc
Copy link
Member Author

nrc commented Oct 23, 2014

r? @nikomatsakis

@alexcrichton
Copy link
Member

also cc @pcwalton, you may be able to review this (we've gotten a lot of duplicate reports about this).

@nick29581, looks like this needs a rebase as well.

@nikomatsakis
Copy link
Contributor

r+ if foo is renamed to something else -- I think there's further cleanup to be done by unifying method/static-method treatment but not necessarily as part of this PR.

@japaric
Copy link
Member

japaric commented Oct 31, 2014

@nick29581 This needs a rebase

bors added a commit that referenced this pull request Oct 31, 2014
@bors bors closed this Nov 1, 2014
@bors bors merged commit 060566f into rust-lang:master Nov 1, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UFCS: ICE in trans when using method from linked crate as function
5 participants