Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add skip(n: uint) to Read, Seek, File, MemReader and BufferedReader #18137

Closed
wants to merge 2 commits into from

Conversation

nodakai
Copy link
Contributor

@nodakai nodakai commented Oct 18, 2014

Resolve #13989

Note: the second patch is based on UFCS and doesn't compile with snapshot 2014-10-10.

I could write unit tests only for Read::skip(). How should I add more?

@rust-highfive
Copy link
Collaborator

warning Warning warning

  • These commits modify unsafe code. Please review it carefully!

@bstrie
Copy link
Contributor

bstrie commented Nov 20, 2014

Wow, sorry for the delay!

This needs a rebase, but I wonder if the changes in the past month (like multidispatch traits) would change how #13989 is approached.

@alexcrichton
Copy link
Member

@nodakai like @bstrie, I'd like to apologize for the delay here, sorry about that! This week @aturon and I have taken a close look at std::io and all known outstanding issues with the module, and we'll be writing up an RFC for the module quite soon. For now I'm going to close this PR as we're going to discuss the skip issue in the RFC, which should help the outcome of this PR maintain consistency with the rest of the module.

Thanks for being patient, and I'll try to be sure to keep you updated on the status of the RFC (coming soon!).

@nodakai nodakai deleted the reader-skip branch June 27, 2020 10:07
lnicola pushed a commit to lnicola/rust that referenced this pull request Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add fn skip(n: uint) with a default implementation to Reader
4 participants