Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guide: Clarify that assigning/comparing different tuple types doesn't work #17836

Merged
merged 1 commit into from
Oct 8, 2014

Conversation

isabelmu
Copy link
Contributor

@isabelmu isabelmu commented Oct 7, 2014

Currently, the Guide says tuples "are only equivalent if the arity, types, and values are all identical", before presenting an example that uses == to compare two tuples whose arity and contained types match. This is misleading, because it implies that == can dynamically check whether two tuples have the same arity and contained types, whereas trying to do this would lead to a compiler error.

I tried to avoid destroying the flow of this section, but I'm not sure if I've been successful.

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @huonw (or someone else) soon.

@steveklabnik
Copy link
Member

Thank you! Good point.

bors added a commit that referenced this pull request Oct 8, 2014
Currently, the Guide says tuples "are only equivalent if the arity, types, and values are all identical", before presenting an example that uses `==` to compare two tuples whose arity and contained types match. This is misleading, because it implies that `==` can dynamically check whether two tuples have the same arity and contained types, whereas trying to do this would lead to a compiler error.

I tried to avoid destroying the flow of this section, but I'm not sure if I've been successful.
@bors bors closed this Oct 8, 2014
@bors bors merged commit c211d13 into rust-lang:master Oct 8, 2014
lnicola pushed a commit to lnicola/rust that referenced this pull request Aug 13, 2024
minor: log error when sysroot can't be discovered

Closes rust-lang#17808
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants