Add ability to change memory protection on std::os::MemoryMap. #17805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @alexcrichton (or someone else) soon. |
|
|
| (true, true, false) => libc::PAGE_EXECUTE_READ, | ||
| (true, true, true) => libc::PAGE_EXECUTE_READWRITE, | ||
| _ => return Err(ErrUnsupProt) | ||
| }; |
There was a problem hiding this comment.
Instead of duplicating the logic above, could it be refactored into a helper function? (same for unix)
|
Closing due to inactivity, but feel free to reopen with my comment addressed! |
lnicola
pushed a commit
to lnicola/rust
that referenced
this pull request
Aug 13, 2024
fix: Panic in path transform with default type parameters Fixes rust-lang#17578
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.