Fix ICE generating drop glue for Box<str>
#17762
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes an ICE. Closes issue rust-lang#17734
|
|
||
| fn f(s: Box<str>) -> Box<str> { | ||
| s | ||
| } |
There was a problem hiding this comment.
Could you check that a dtor on str is called in this test?
There was a problem hiding this comment.
str is a built-in type (and doesn't itself have a destructor), do you have a cross-platform way to do the check you want?
There was a problem hiding this comment.
Unless I'm missing something, there doesn't seem to be any way to construct a Box<str> safely at the moment. I could produce one by creating a Box<[u8]> and transmuting, but I'm not sure how to test that the destructor fires correctly.
|
I updated the test to be a bit more interesting at runtime. I'm not sure how to programmatically check that the box is dropped correctly, but I verified that the generated IR and asm looks right. |
bors
added a commit
that referenced
this pull request
Oct 5, 2014
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes issue #17734
r? @nick29581