Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ICE regression test for issue #16218. #17062

Merged
merged 1 commit into from
Sep 9, 2014

Conversation

nathantypanski
Copy link
Contributor

This code used to produce an ICE on the definition of trait Bar
with the following message:

Type parameter out of range when substituting in region 'a (root
type=fn(Self) -> 'astr) (space=FnSpace, index=0)

Closes #16218.

@nathantypanski nathantypanski force-pushed the generic-lifetime-trait-impl branch from 2bba56f to 344613a Compare September 7, 2014 05:54
This code used to produce an ICE on the definition of trait Bar
with the following message:

Type parameter out of range when substituting in region 'a (root
type=fn(Self) -> 'astr) (space=FnSpace, index=0)

Closes rust-lang#16218.
@nathantypanski nathantypanski force-pushed the generic-lifetime-trait-impl branch from 344613a to d80729a Compare September 7, 2014 07:58
@brson
Copy link
Contributor

brson commented Sep 8, 2014

😍

alexcrichton added a commit to alexcrichton/rust that referenced this pull request Sep 9, 2014
@bors bors merged commit d80729a into rust-lang:master Sep 9, 2014
lnicola pushed a commit to lnicola/rust that referenced this pull request Apr 20, 2024
…r=Veykril

Temporarily disable unlinked file popup

Not gonna look into this until the next release, so I'd rather disable it for the time being
lnicola pushed a commit to lnicola/rust that referenced this pull request Apr 20, 2024
…r=Veykril

Temporarily disable unlinked file popup

Not gonna look into this until the next release, so I'd rather disable it for the time being
lnicola pushed a commit to lnicola/rust that referenced this pull request Jul 11, 2024
fix: Improve hover text in unlinked file diagnostics

Use full sentences, and mention how to disable the diagnostic if users are intentionally working on unowned files.

![Screenshot 2024-06-12 at 5 55 48 PM](https://github.com/rust-lang/rust-analyzer/assets/70800/c91ee1ed-1c72-495a-9ee3-9e360a5c6977)

(Full disclosure: I've tested a rust-analyzer build in VS Code, but the pop-up logic is currently disabled due to rust-lang#17062, so I haven't tested that.)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ICE with mismatching lifetime generics between trait and impl
4 participants