Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mark win32 binaries as large address aware #17053

Merged
merged 1 commit into from
Sep 8, 2014
Merged

mark win32 binaries as large address aware #17053

merged 1 commit into from
Sep 8, 2014

Conversation

thestinger
Copy link
Contributor

By default, 32-bit Windows executables are restricted to 2GiB of address
space even when running on 64-bit Windows when 4GiB is available.

Closes #17043

By default, 32-bit Windows executables are restricted to 2GiB of address
space even when running on 64-bit Windows when 4GiB is available.

Closes #17043
@luqmana
Copy link
Member

luqmana commented Sep 7, 2014

And then we can remove https://github.com/rust-lang/rust/blob/master/mk/platform.mk#L464 after a snapshot.

bors added a commit that referenced this pull request Sep 8, 2014
…r,cmr

By default, 32-bit Windows executables are restricted to 2GiB of address
space even when running on 64-bit Windows when 4GiB is available.

Closes #17043
@bors bors closed this Sep 8, 2014
@bors bors merged commit c6633fd into rust-lang:master Sep 8, 2014
@thestinger thestinger deleted the large_address_aware branch September 8, 2014 17:50
lnicola pushed a commit to lnicola/rust that referenced this pull request Apr 20, 2024
…iable, r=Veykril

fix: Replace Just the variable name in Unused Variable Diagnostic Fix

Changes Unused Variable diagnostic to just look at the variable name, not the entire syntax range.

Also added a test for an unused variable in an array destructure.

Closes rust-lang#17053
lnicola pushed a commit to lnicola/rust that referenced this pull request Apr 20, 2024
…iable, r=Veykril

fix: Replace Just the variable name in Unused Variable Diagnostic Fix

Changes Unused Variable diagnostic to just look at the variable name, not the entire syntax range.

Also added a test for an unused variable in an array destructure.

Closes rust-lang#17053
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Windows: 32-bit rust executables are not marked as "large address aware"
3 participants