librustc: Obsolete the old external crate renaming syntax. #17048
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -87,6 +88,10 @@ impl<'a> ParserObsoleteMethods for parser::Parser<'a> { | |||
| ObsoleteImportRenaming => ( | |||
| "`use foo = bar` syntax", | |||
| "write `use bar as foo` instead" | |||
| ), | |||
| ObsoleteExternCrateRenaming => ( | |||
| "`extern crate foo = bar` syntax", | |||
There was a problem hiding this comment.
I think the RHS here (and LHS) should be strings.
pcwalton
force-pushed
the
remove-old-import-renaming-syntax
branch
2 times, most recently
from
7c5cd77 to
ec1ce6a
Compare
Instead of `extern crate foo = bar`, write `extern crate bar as foo`. Instead of `extern crate baz = "quux"`, write `extern crate "quux" as baz`. Closes rust-lang#16461. [breaking-change]
pcwalton
force-pushed
the
remove-old-import-renaming-syntax
branch
from
ec1ce6a to
1bce869
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of
extern crate foo = bar, writeextern crate bar as foo.Instead of
extern crate baz = "quux", writeextern crate "quux" as baz.Closes #16461.
[breaking-change]
r? @brson