librustc: Implement the syntax in the RFC for unboxed closure sugar. #17041
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Where did this syntax come from? I don't remember seeing it in the RFC. |
|
I remember seeing this discussed as an alternative, but not agreed upon in the RFC. |
pcwalton
force-pushed
the
right-unboxed-closure-sugar
branch
from
be68169
to
b2ca3cc
Compare
| this.tcx().sess.span_err(b.path.span, | ||
| "unboxed function trait must be one \ | ||
| of `Fn`, `FnMut`, or `FnOnce`"); | ||
| ast::FnMutUnboxedClosureKind |
There was a problem hiding this comment.
Can you add a test for this error?
|
r=me with some tests |
Part of issue rust-lang#16640. I am leaving this issue open to handle parsing of higher-rank lifetimes in traits. This change breaks code that used unboxed closures: * Instead of `F:|&: int| -> int`, write `F:Fn(int) -> int`. * Instead of `F:|&mut: int| -> int`, write `F:FnMut(int) -> int`. * Instead of `F:|: int| -> int`, write `F:FnOnce(int) -> int`. [breaking-change]
pcwalton
force-pushed
the
right-unboxed-closure-sugar
branch
from
b2ca3cc
to
7c00d77
Compare
alexcrichton
added a commit
to alexcrichton/rust
that referenced
this pull request
Sep 19, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of issue #16640. I am leaving this issue open to handle parsing of
higher-rank lifetimes in traits.
This change breaks code that used unboxed closures:
F:|&: int| -> int, writeF:Fn(int) -> int.F:|&mut: int| -> int, writeF:FnMut(int) -> int.F:|: int| -> int, writeF:FnOnce(int) -> int.[breaking-change]
r? @alexcrichton