Detect traits being used as structs in check_expr_with_unifier #16867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you add a test for this as well? |
|
And yes adding an error code is fine, thanks! |
| @@ -3982,6 +3998,16 @@ fn check_expr_with_unifier(fcx: &FnCtxt, | |||
| variant_id, fields.as_slice()); | |||
| enum_id | |||
| } | |||
| Some(def::DefTrait(def_id)) => { | |||
| span_err!(tcx.sess, path.span, E0159, | |||
| "`{}` is a trait not a structure", | |||
There was a problem hiding this comment.
Maybe this could be "use of trait {} as a struct constructor"
|
(docs about these sort of tests, it should be in |
Changed error to 'use of trait `{}` as a struct constructor'
ghost
mentioned this pull request
lnicola
pushed a commit
to lnicola/rust
that referenced
this pull request
Apr 7, 2024
update: add editor/extension information to bug report template When attempting to reproduce issues, I encounter difficulties due to differences in versions of LSP clients and editors (such as rust-lang#16985, rust-lang#16867, and more) This sometimes consumes a lot of efforts from contributors to communicate the details about LSP client information. Therefore, I believe adding editor/extension information to the issue template would be helpful for problem reproduction.
lnicola
pushed a commit
to lnicola/rust
that referenced
this pull request
Apr 20, 2024
update: add editor/extension information to bug report template When attempting to reproduce issues, I encounter difficulties due to differences in versions of LSP clients and editors (such as rust-lang#16985, rust-lang#16867, and more) This sometimes consumes a lot of efforts from contributors to communicate the details about LSP client information. Therefore, I believe adding editor/extension information to the issue template would be helpful for problem reproduction.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if this is addressing the root cause or just patching up a symptom. Also not sure if I should be adding a diagnostic code for this.
Fixes #16750
Fixes #15812